Review Request: Don't select extension by default in the file name conflict dialog box

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3457/#review5304
-----------------------------------------------------------

Ship it!


Looks good, just 2 minor things. Ah, you still don't have a SVN account, right? You should definitely apply for one, see http://techbase.kde.org/Contribute/Get_a_SVN_Account

I'll make the changes and commit, then.


/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://reviewboard.kde.org/r/3457/#comment4984>

    I don't think the .toLower() is necessary; the mimetype system takes care of case when matching mimetypes



/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://reviewboard.kde.org/r/3457/#comment4983>

    if (!extension.isEmpty())
     is the more standard Qt way


- David


On 2010-04-24 15:07:42, Todd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3457/
> -----------------------------------------------------------
> 
> (Updated 2010-04-24 15:07:42)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> When copying or moving a file, if there is a file name conflict a dialog box pops up.  Generally when you have such a conflict, I would expect most people who wish to rename the file being copied or moved would want to only change the file name, not the extension.  However, presently both the filename and the file extension are selected initially.  This patch changes this behavior so only the file name (not the extension) is selected.  This is also consistent with the dolphin file rename behavior.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1117311 
> 
> Diff: http://reviewboard.kde.org/r/3457/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Todd
> 
>