New dependency for kdelibs and kdebase: dbusmenu-qt
agateau at kde.org
Thu Apr 29 10:38:25 BST 2010
On 26/04/2010 13:12, Christoph Feck wrote:
> On Sunday 25 April 2010 22:45:56 Aurélien Gâteau wrote:
>> I just committed support for DBusMenu in kdelibs and kdebase.
> Some issues I noticed:
> * dbusmenu-qt fails to build
> In FindQJSON.cmake, you try to find the include file "parser.h", but later
> include <qjson/parser.h>. This then fails with the error "include file
> qjson/parser.h not found", because it apparently tries to look at
> "qjson/qjson/parser.h". I had to change FindQJSON.cmake. Diff below.
Including "parser.h" felt a bit ugly anyway, or at least too generic.
Thanks for fixing. FindQJSON.cmake was created by libqjson author, so I
will report the fix to him as well.
> * kdelibs fails to build
> I am not entirely sure if my guess is right, but there seems to be some
> inconsistency with the prefix name for dbusmenu-qt ("DBusMenu-Qt" vs.
> "DBusMenuQt"). When running cmake in kdelibs, i get a message that dbusmenu-qt
> version 0.3.2 is found, then later it claims that required dependency
> dbusmenu-qt is not installed (but it is).
> I only checked the changes in kdelibs quickly; I noticed that you use include
> "stuff" instead of include <stuff> to include the dependend dbusmenu headers;
> since this is an external requirement, it should use the angle brackets.
More information about the kde-core-devel