Review Request: Hunspell support for legacy KSpell/K3Spell

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2762/#review5294
-----------------------------------------------------------

Ship it!


I don't see a problem with this being committed, if you maintain that code - i.e. somehow get the bug reports for it :-)

- David


On 2010-01-29 17:05:46, Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2762/
> -----------------------------------------------------------
> 
> (Updated 2010-01-29 17:05:46)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> In Fedora, we are trying to reduce the proliferation of dictionaries and spellchecking tools. Therefore, we want to make as many applications as possible use the hunspell spellchecker, either directly or through the enchant abstraction layer. See http://fedoraproject.org/wiki/Releases/FeatureDictionary for details.  This will also ensure KDE 4 apps use the same spellchecking dictionaries, whether they use Sonnet or the KDE 3 compatibility interfaces (and incidentally also the same ones as other applications). (Backported patches for KDE 3 KSpell and KSpell2 are also available.)
> 
> We implemented support for the Hunspell command-line spellchecker (which has an ispell-compatible pipe interface) in the K3Spell compatibility class (which provides support for the legacy "KSpell 1" interface and is still used in some apps).
> 
> We think this could be useful in upstream KDE so all KDE 4 apps can be used without installing a second spellchecker.
> 
> Using this patch, folks will want to set these in their default kdeglobals:
> [K3Spell]
> K3Spell_Client=4
> K3Spell_Encoding=11
> 
> This was originally submitted as part of http://bugs.kde.org/154561 and was marked WONTFIX, but we'd like a broader discussion and feedback.  At best, that bug was inconclusive in that Zach simply didn't have time for kde3support items.
> 
> 
> This addresses bug 154561.
>     https://bugs.kde.org/show_bug.cgi?id=154561
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kde3support/kdeui/k3sconfig.h 1082077 
>   /trunk/KDE/kdelibs/kde3support/kdeui/k3sconfig.cpp 1082077 
>   /trunk/KDE/kdelibs/kde3support/kdeui/k3spell.cpp 1082077 
> 
> Diff: http://reviewboard.kde.org/r/2762/diff
> 
> 
> Testing
> -------
> 
> Such support has been included in Fedora, since Fedora 9 and kde-4.0.
> 
> 
> Thanks,
> 
> Rex
> 
>