[PATCH] Request review for KSharedDataCache (Round 2)

[Brad Hards]

On Wednesday 28 April 2010 08:20:37 pm Oswald Buddenhagen wrote:
> > > > +    enum EvictionPolicy
> > > > +    {
> > > > +        // It's important that the default value be 0 due to mmap().
> > > 
> > > grammar
> > 
> > I actually disagree this time, but I will remove the contraction to make
> > it clear (i.e. "It is important that the default value be 0, due to
> > mmap()")
> 
> i meant "that the [...] value _be_ 0". i don't know whether this is
> actually wrong, but i usually see this in constructs which are
> artificially arcane/wrong. more compliant with my perception of
> correctness would be "is".
I think either is OK. A more direct approach would be something like
"The default value must be 0, since it will be passed to mmap()"

Brad