Review Request: Add ffmpegthumbnailer for video previews
Christoph Feck
christoph at maxiom.de
Tue Apr 27 18:27:52 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3818/#review5263
-----------------------------------------------------------
There is probably something I miss, but could you explain
* how your cmake files handle the case when FFmpeg is not found
* why the code saves the image data to PNG, then loads it from PNG
* why there is code to handle JPEG format and command line arguments when those are not needed?
Thanks.
- Christoph
On 2010-04-27 13:07:39, Andreas Scherf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3818/
> -----------------------------------------------------------
>
> (Updated 2010-04-27 13:07:39)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> This change adds a ffmpegbackend for rendering video thumbnails
> FFMPEG is required for this.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdemultimedia/CMakeLists.txt 1119516
> /trunk/KDE/kdemultimedia/ffmpegthumbs/CMakeLists.txt PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer.cpp PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/.directory PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/AUTHORS PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ChangeLog PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/README PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.cpp PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/grayscalefilter.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/histogram.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ifilter.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/imagetypes.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/imagewriter.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/imagewriterfactory.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/jpegwriter.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/jpegwriter.cpp PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/main.cpp PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.cpp PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/pngwriter.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/pngwriter.cpp PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/stringoperations.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/stringoperations.cpp PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videoframe.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.cpp PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailerc.h PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailerc.cpp PRE-CREATION
> /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbs.desktop PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/3818/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Dolphin with ffmpegthumbs
> http://reviewboard.kde.org/r/3818/s/375/
>
>
> Thanks,
>
> Andreas
>
>
More information about the kde-core-devel
mailing list