watch out for badly-formed patches

Chani chanika at
Tue Apr 27 00:03:40 BST 2010

just wanted to warn you guys, what you see in kompare *might* not be what's 
really in a patch (if the patch is badly formed). since a lot of us are 
reviewing patches on reviewboard these days, and actually *applying* a bad 
patch would set off warnings, it's probably not such a big deal... but if 
you're reading .diff files, doublecheck the plain text before approving things.

I caught the problem because I was sent a patch that appeared to be useless:

kevin's working on a patch now, so this should be solved soonish :)
actually, he's also looking for a new maintainer... anyone interested in 
taking care of kompare?

This message brought to you by eevil bananas and the number 3.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list