Review Request: Add a generic shared-memory cache to kdelibs, to deprecate KPixmapCache and make it more useful in general.

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3809/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

This is a review request of the patchset that adds KImageCache and KSharedDataCache for the convenience of those who really love ReviewBoard. I can put the rest of the patchset up as well if there is interest.


Diffs
-----

  /trunk/KDE/kdelibs/kdecore/CMakeLists.txt 1118716 
  /trunk/KDE/kdelibs/kdecore/util/kshareddatacache.h PRE-CREATION 
  /trunk/KDE/kdelibs/kdecore/util/kshareddatacache.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1118716 
  /trunk/KDE/kdelibs/kdeui/util/kimagecache.h PRE-CREATION 
  /trunk/KDE/kdelibs/kdeui/util/kimagecache.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3809/diff


Testing
-------

I've been running this code for about a month straight now. Some testing has been done in valgrind (callgrind specifically) to look for egregrious inefficiencies. Memory usage has been checked by using KRunner/KSysGuard's detailed memory listing from trunk (short story is that I'm not sure it really helps much for memory usage). A previous revision had a Model/View interface accessible which I had a specific tool for, but that interface is no longer accessible.


Thanks,

Michael