Review Request: Allow kio jobs total size to decrease

Albert Astals Cid aacid at kde.org
Sun Apr 25 23:12:59 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3807/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Currently kio jobs only emit/accept new total sizes when the size given is bigger than the previous one, this is probably OK for most of the cases, but for the audiocd:/ kioslave it is not, because the audiocd:/ ioslave is basically estimating all the time the size the final encoded file will have and most of the time it overestimates at the beginning so it emits new smaller totalsizes while it's progressing, but as kio jobs ignore that you usually end up with a file that "ends" at 50%


Diffs
-----

  trunk/KDE/kdelibs/kio/kio/copyjob.cpp 1118295 
  trunk/KDE/kdelibs/kio/kio/job.cpp 1118295 

Diff: http://reviewboard.kde.org/r/3807/diff


Testing
-------

Fixes my audiocd:/ problem


Thanks,

Albert





More information about the kde-core-devel mailing list