Review Request: fix rendering of klineedit clear button

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3804/
-----------------------------------------------------------

(Updated 2010-04-25 02:35:12.769937)


Review request for kdelibs.


Changes
-------

sorry. Removed trailing spaces in empty lines.


Summary
-------

this patch
- fixes the rendering of animated klineedit clear button, to use QPainter compositing mode rather than QPainter::setOpacity to fake semi-transparent clearButton during animation. This should be more efficient as QPainter::setOpacity (last time I checked) was using the rasterEngine. 

- uses a QIcon rather than QPixmap to store the clearButton pixmap. This allows to have the proper icon effect when rendering enabled/disabled klineedit. 


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h 1118236 

Diff: http://reviewboard.kde.org/r/3804/diff


Testing
-------

in konqueror and dolphin, as well as custom made test widgets.
Test done in klineedit, as well as editable kcombobox
Using either oxygen, cleanlooks and plastik style. 

Finally, tested with/without the animation being enabled


Thanks,

Hugo