Review Request: Don't select extension by default in the file name conflict dialog box

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3457/#review5197
-----------------------------------------------------------


Assuming you have covered all the places where the rename dialog text is set, the code seems fine with the exception of the comments noted.


/trunk/KDE/kdelibs/kio/kio/renamedialog.h
<http://reviewboard.kde.org/r/3457/#comment4695>

    This should be put into the Private class in the .cpp instead of renamedialog.h. No need to change the object layout or installed headers if we don't need too, even if it does remain binary compatible.



/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://reviewboard.kde.org/r/3457/#comment4693>

    Don't change the parentheses spacing here, just the function name. The original code is not per the kdelibs code style policy but that should be fixed in its own separate commit.



/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://reviewboard.kde.org/r/3457/#comment4694>

    Same comment about changing code style as on line 286.



/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp
<http://reviewboard.kde.org/r/3457/#comment4692>

    Does this calculation work if no extension was found? (i.e. extension.length() == 0) It looks like every character except the very last one would be highlighted in that case.


- Michael


On 2010-03-31 04:58:07, Todd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3457/
> -----------------------------------------------------------
> 
> (Updated 2010-03-31 04:58:07)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> When copying or moving a file, if there is a file name conflict a dialog box pops up.  Generally when you have such a conflict, I would expect most people who wish to rename the file being copied or moved would want to only change the file name, not the extension.  However, presently both the filename and the file extension are selected initially.  This patch changes this behavior so only the file name (not the extension) is selected.  This is also consistent with the dolphin file rename behavior.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.h 1109338 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1109338 
> 
> Diff: http://reviewboard.kde.org/r/3457/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Todd
> 
>