Review Request: Expose KStatusNotifierItem menus on DBus

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3787/#review5191
-----------------------------------------------------------

Ship it!


is still a work in progress, but as soon the dependency from qtdbusmenu is sorted out i think it should go in


trunk/KDE/kdelibs/CMakeLists.txt
<http://reviewboard.kde.org/r/3787/#comment4683>

    should have at least a copy of it in kdesupport?



trunk/KDE/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp
<http://reviewboard.kde.org/r/3787/#comment4685>

    this should be a bit prettier, but would be good if the env variable stays


- Marco


On 2010-04-23 16:15:06, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3787/
> -----------------------------------------------------------
> 
> (Updated 2010-04-23 16:15:06)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes KStatusNotifierItem expose its menu on DBus, making it possible for the StatusNotifierItem visualization to control the rendering of the menu. It adds a dependency on dbusmenu-qt, which can be found here:
> 
> http://people.canonical.com/~agateau/dbusmenu/index.html
> 
> For now icon names are not exposed because it needs QIcon::name(). This method should be in Qt 4.7, but was not included in the beta.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/CMakeLists.txt 1115427 
>   trunk/KDE/kdelibs/cmake/modules/CMakeLists.txt 1115427 
>   trunk/KDE/kdelibs/cmake/modules/FindDBusMenuQt.cmake PRE-CREATION 
>   trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1115427 
>   trunk/KDE/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp 1115427 
>   trunk/KDE/kdelibs/kdeui/notifications/kstatusnotifieritemdbus_p.h 1115427 
>   trunk/KDE/kdelibs/kdeui/notifications/kstatusnotifieritemdbus_p.cpp 1115427 
>   trunk/KDE/kdelibs/kdeui/notifications/kstatusnotifieritemprivate_p.h 1115427 
>   trunk/KDE/kdelibs/kdeui/notifications/org.ayatana.dbusmenu.xml PRE-CREATION 
>   trunk/KDE/kdelibs/kdeui/notifications/org.kde.StatusNotifierItem.xml 1115427 
> 
> Diff: http://reviewboard.kde.org/r/3787/diff
> 
> 
> Testing
> -------
> 
> After applying the patch you should be able to list the menu of a KSNI-enabled application from DBus. This can be checked with this command:
> 
> dbus-send --print-reply --dest=org.kde.StatusNotifierItem-$PID-$N /MenuBar org.ayatana.dbusmenu.GetChildren int32:0 array:string:
> 
> 
> Thanks,
> 
> Aurélien
> 
>