Review Request: Path or URL as additional information in KFileItemDelegate

[Fredrik Höglund]

> On 2010-03-24 20:22:46, Peter Penz wrote:
> > I agree that it will be nice having a path or URL as additional information in Dolphin/Konqueror. Will this information also be used outside Dolphin/Konqueror during KDE SC 4.5? If not, maybe we should add the column into the DolphinModel instead and move it to kdelibs later. The maintainer of KFileItemDelegate is Fredrik Höglund, hopefully he can give us his point of view to this topic.
> 
> Sebastian Trueg wrote:
>     what is the status on this one?

Sorry, I missed this patch until now.

I haven't tested it, but the code looks good to me.

As for whether DolphinModel is a better place for it, I guess that can only be answered
by the question Peter already asked; in which apps other than Dolphin and Konqueror would
it be useful to show that column? :)


- Fredrik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3354/#review4668
-----------------------------------------------------------


On 2010-03-23 17:02:32, Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3354/
> -----------------------------------------------------------
> 
> (Updated 2010-03-23 17:02:32)
> 
> 
> Review request for kdelibs and Peter Penz.
> 
> 
> Summary
> -------
> 
> Especially for search results users might be interested in the local path of a search result. This information is available from the properties dialog but this is rather clumsy. A simple solution is to add the path (or URL) as an additional property to show in the KDirModel. This patch provides exactly that (followed by a patch for Dolphin as soon as accepted).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.h 1106581 
>   /trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp 1106581 
> 
> Diff: http://reviewboard.kde.org/r/3354/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>