[KDE Usability] Review Request: KAuth support in KDM kcontrol module

[Oswald Buddenhagen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3631/#review5129
-----------------------------------------------------------


hi, thanks. looks a lot more secure now. :)
i dislike how the background class does the handling of the temporary file itself and has the save() method return its name. it would be a lot cleaner if the main module would set up that one as well and pass the temporary config object to the background class.


/trunk/KDE/kdebase/workspace/kcontrol/kdm/background.cpp
<http://reviewboard.kde.org/r/3631/#comment4628>

    this would have to be a member of KBackground if it were to stay.
    



/trunk/KDE/kdebase/workspace/kcontrol/kdm/background.cpp
<http://reviewboard.kde.org/r/3631/#comment4627>

    systemBackgroundConfig.copyTo(tempBackgroundConfigName, pTempConfig);
    pTempConfig.sync()
    return pTempConfig;
    



/trunk/KDE/kdebase/workspace/kcontrol/kdm/kcmkdm_actions.actions
<http://reviewboard.kde.org/r/3631/#comment4629>

    "Administrator authorization is required to change the Login Manager settings."
    
    this sounds less negative. additionally, it gives a clue who's password is being asked for (though really, i think it would be the task of the framework do tell that).
    


- Oswald


On 2010-04-19 20:43:44, Igor Krivenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3631/
> -----------------------------------------------------------
> 
> (Updated 2010-04-19 20:43:44)
> 
> 
> Review request for kdelibs, usability, Dario Freddi, Oswald Buddenhagen, and Frederik Gladhorn.
> 
> 
> Summary
> -------
> 
> This is a patch for KDM kcontrol module.
> It implements Kauth support for changing kdm settings and managing user images. 
> It still doesn't support installation/deletion of themes (including installation via knewstuff).
> As far as I know there were plans to port KNewStuff3 to KAuth, so a more consistent approach is
> to rely on the KNewStuff's integration when it's available.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/CMakeLists.txt 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.h 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.cpp 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kcmkdm_actions.actions PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.h 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.cpp 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.h 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.cpp 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.h 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.cpp 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.h 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.cpp 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.h 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.cpp 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.h 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.cpp 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.h 1113083 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.cpp 1113083 
> 
> Diff: http://reviewboard.kde.org/r/3631/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Saving KDM settings
>   http://reviewboard.kde.org/r/3631/s/360/
> Managing user images
>   http://reviewboard.kde.org/r/3631/s/361/
> 
> 
> Thanks,
> 
> Igor
> 
>