Review Request: Add "QString iconName()" method to KIcon

Aurélien Gâteau agateau at
Tue Apr 20 16:48:45 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-04-20 15:48:44.137484)

Review request for kdelibs, Marco Martin and Hamish Rodda.


The Qt version has been merged and will be in 4.7 (Thanks Olivier!). Here is a rewrite of the patch which takes advantage of the new QIconEngineV2::IconNameHook.

Now the only ugly part of this is that we do not depend on 4.7 yet, so I declared IconNameHook as a #define, see the FIXME line.


This patch is a necessary step for dbusmenu [1]: To be able to export a menu over dbus, we need to know the name of the icons, thus the need for a "QString KIcon::iconName()" method.

As you can see in the code comment, I am not really happy with the way it is implemented, but do not see any other way.


Diffs (updated)

  trunk/KDE/kdelibs/kdeui/icons/kiconengine.cpp 1115427 
  trunk/KDE/kdelibs/kdeui/icons/kiconengine_p.h 1115427 





More information about the kde-core-devel mailing list