Review Request: Better TagWidget in libnepomuk

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3669/#review5113
-----------------------------------------------------------


I've tried the test application and I think the widget can be very useful. For me a little bit confusing was the "All Tags..." button, maybe renaming it to "Show All Tags..." would be preferable?

I'm not sure whether being able to click on tags itself (-> tagClicked() gets emitted) should be made optional - probably some applications don't want/cannot react on this.

If the tag edit should be moved to Nepomuk, please just let me know and I'll adjust the class with a private d-pointer etc.

One minor issue I've seen: It seems the size hint of the widget must be optimized, currently it is possible without problem to move the "All Tags..." button below the checkboxes (but most probably you are aware of this, I guess this request concentrated more on the usability of the widget ;-))

- Peter


On 2010-04-19 11:28:06, Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3669/
> -----------------------------------------------------------
> 
> (Updated 2010-04-19 11:28:06)
> 
> 
> Review request for kdelibs and Peter Penz.
> 
> 
> Summary
> -------
> 
> Nepomuk::TagWidget has been there forever but due to its being rather unintuitive and ugly (despite my efforts of making it fancy back in the day) it is not used at all. Since we have the class in kdelibs and a tagging widget is a typical thing to use I made another attempt at creating a generic one that apps ca use. It basically shows a list of checkboxes of the N most often used tags and has a button to show all tags. This button will bring up the exact dialog used in Dolphin and Gwenview (the one from KIO). So far the code cannot be shared since we cannot link libnepomuk against kio. But maybe we could do it the other way around and move the tag edit dialog into libnepomuk as a public class.
> 
> Anyway, this review request is about the new TagWidget and whether it has a chance to be used. I added a simple test app that allows to toy around with the widget.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/includes/CMakeLists.txt 1114717 
>   trunk/KDE/kdelibs/includes/Nepomuk/TagWidget PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/core/CMakeLists.txt 1114717 
>   trunk/KDE/kdelibs/nepomuk/core/ui/CMakeLists.txt 1114717 
>   trunk/KDE/kdelibs/nepomuk/core/ui/kautoscrollarea.h 1114717 
>   trunk/KDE/kdelibs/nepomuk/core/ui/kautoscrollarea.cpp 1114717 
>   trunk/KDE/kdelibs/nepomuk/core/ui/kblocklayout.h 1114717 
>   trunk/KDE/kdelibs/nepomuk/core/ui/kblocklayout.cpp 1114717 
>   trunk/KDE/kdelibs/nepomuk/core/ui/kedittagsdialog.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/core/ui/kedittagsdialog_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/core/ui/kmetadatatagwidget.h 1114717 
>   trunk/KDE/kdelibs/nepomuk/core/ui/kmetadatatagwidget.cpp 1114717 
>   trunk/KDE/kdelibs/nepomuk/core/ui/tagcheckbox.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/core/ui/tagcheckbox.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/core/ui/tagwidget.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/core/ui/tagwidget.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/core/ui/test/CMakeLists.txt 1114717 
>   trunk/KDE/kdelibs/nepomuk/core/ui/test/tagwidgetapp.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/core/ui/test/tagwidgettest.h PRE-CREATION 
>   trunk/KDE/kdelibs/nepomuk/core/ui/test/tagwidgettest.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3669/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>