Review Request: Add support for subgroups to kconf_update

Aurélien Gâteau agateau at kde.org
Mon Apr 19 13:43:00 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3623/
-----------------------------------------------------------

(Updated 2010-04-19 12:43:00.615691)


Review request for kdelibs.


Changes
-------

Applied Oswald suggestions.


Summary
-------

This huge patch adds the ability to manipulate subgroups to kconf_update. It is now possible to specify a group either as "group" or as "[group][subgroup]".


Diffs (updated)
-----

  trunk/KDE/kdelibs/kconf_update/CMakeLists.txt 1115427 
  trunk/KDE/kdelibs/kconf_update/README.kconf_update 1115427 
  trunk/KDE/kdelibs/kconf_update/kconf_update.cpp 1115427 
  trunk/KDE/kdelibs/kconf_update/kconfigutils.h PRE-CREATION 
  trunk/KDE/kdelibs/kconf_update/kconfigutils.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kconf_update/tests/CMakeLists.txt 1115427 
  trunk/KDE/kdelibs/kconf_update/tests/test_kconf_update.cpp 1115427 
  trunk/KDE/kdelibs/kconf_update/tests/test_kconfigutils.h PRE-CREATION 
  trunk/KDE/kdelibs/kconf_update/tests/test_kconfigutils.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3623/diff


Testing
-------

Unit-tests for kconf_update I wrote before adding support for subgroups still pass. I also extended the existing tests and added new ones to test the subgroup support.


Thanks,

Aurélien





More information about the kde-core-devel mailing list