Review Request: Add support for AlphaChannel to KColorDialog
Olivier Goffart
ogoffart at kde.org
Thu Apr 15 19:23:13 BST 2010
Hi, I would use reviewboard, but I lost my password (I blame KWallet for this
:-))
Nice patch. (I had report from Qt users had reported that their
QColorDialog::ShowAlphaChannel was not anymore working on KDE)
For the patch in qguiplatformplugin_kde.cpp, I would have put the two new line
outside of the if, just before the setVisible, so it is updated is that flag
changes between two show.
--
Gof
Le Sunday 11 April 2010, Christoph Feck a écrit :
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3566/
> -----------------------------------------------------------
>
> Review request for Gwenview, kdelibs and usability.
>
>
> Summary
> -------
>
> Add an "alphaChannelEnabled" property to KColorDialog to support
> QColorDialog::ShowAlphaChannel. Requires the patch from
> http://reviewboard.kde.org/r/3565 to show the alpha gradient.
>
> Please comment on:
> * name/description of newly added methods in KColorDialog
> * visible "Alpha" label ("Opacity"?)
> * placement of widgets (yes, Alpha label should be aligned to RGB labels,
> but how?)
>
>
> Diffs
> -----
>
>
> /trunk/KDE/kdebase/workspace/qguiplatformplugin_kde/qguiplatformplugin_kde
> .cpp 1113711 /trunk/KDE/kdelibs/kdeui/colors/kcolordialog.h 1113786
> /trunk/KDE/kdelibs/kdeui/colors/kcolordialog.cpp 1113786
>
> Diff: http://reviewboard.kde.org/r/3566/diff
>
>
> Testing
> -------
>
> I used this to test integration with QColorDialog:
>
> #include <QtGui/QApplication>
> #include <QtGui/QColorDialog>
> #include <QtCore/QDebug>
>
> int main(int argc, char *argv[])
> {
> QApplication app(argc, argv);
> QColor color = QColorDialog::getColor(QColor(255, 0, 0, 100), 0,
> "Select ARGB Color", QColorDialog::ShowAlphaChannel); qDebug() << color;
> }
>
>
> Screenshots
> -----------
>
> KColorDialog with enabled AlphaChannel
> http://reviewboard.kde.org/r/3566/s/354/
>
>
> Thanks,
>
> Christoph
More information about the kde-core-devel
mailing list