Review Request: Mouse wheel interaction with breadcrumb-style address bar
Todd
toddrme2178 at gmail.com
Thu Apr 15 15:31:23 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2330/
-----------------------------------------------------------
(Updated 2010-04-15 14:31:23.139845)
Review request for Dolphin and kdelibs.
Changes
-------
I made the changes you requested. I'm sorry, I don't have svn access. Would you be able to apply it? Thanks.
Summary
-------
This patch allows mouse wheel interaction with the breadcrumb (not editable) address bar used in programs like Dolphin. Currently this version of the address bar does not have any mouse wheel interaction, so this patch does not interfere with existing functionality.
There are two different interactions supported:
First, when the vertical mouse wheel (any normal mouse wheel) is used on one of the folders, it moves through the folders in the same level in alphabetical order. So say you have a folder in your Home directory named "test", with 5 sub-folders, folder1, folder2, folder3, folder4, and folder5. You are currently in folder3. If you put your mouse over the folder3 entry in the address bar and rotate your mouse wheel down by one notch, you will switch to folder4. If you rotate your mouse wheel up by one notch, you will move to folder2. Move down and up by 2 (or more, in this case) notches moves you to folder5 and folder1, respectively. While in any of these folders, using your mouse wheel on the "test" folder entry will cycle through the other subfolders in your Home directory (since those folders are at the same level as test). When you reach the first or last folder in the directory further mouse wheel activity in that direction does nothing.
The second functionality is provided when doing a horizontal scroll (generally alt+wheel) anywhere on the breadcrumb-style address bar. In this case, rotating the wheel by one notch in either direction moves you up one directory. In other words, holding alt and rotating the mouse wheel by one notch is equivalent to hitting the "Up" toolbar button once.
This patch does not change the mouse wheel behavior of the traditional text-based (editable) address bar.
I know this won't make it in before 4.5.
Diffs (updated)
-----
/trunk/KDE/kdelibs/kfile/kurlnavigatorbutton.cpp 1114566
/trunk/KDE/kdelibs/kfile/kurlnavigatorbutton_p.h 1114566
Diff: http://reviewboard.kde.org/r/2330/diff
Testing
-------
Thanks,
Todd
More information about the kde-core-devel
mailing list