Review Request: Escape key to close old-style location combo box also switches back to breadcrumb navigation

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3613/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

In Dolphin or the open/save file dialogue when using the old-style URL combo box,
clicking on the combo box down-arrow as if intending to select something from the
history and then pressing Escape switches back to the breadcrumb navigation bar.
The expected behaviour would be that the combo box dropdown simply disappears.

By acting on the KUrlNavigator's keyPressEvent instead of keyReleaseEvent, the combo box
close event is not passed on to its parent widget and the navigation bar is not switched.


This addresses bug 200842.
    https://bugs.kde.org/show_bug.cgi?id=200842


Diffs
-----

  /trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 1114484 
  /trunk/KDE/kdelibs/kfile/kurlnavigator.h 1114484 

Diff: http://reviewboard.kde.org/r/3613/diff


Testing
-------

Tested Dolphin and the open/save dialogue with these changes.  The bar does not
switch back to breadcrumb navigation if the Escape key is pressed to close the combo.
Pressing Escape while the combo box dropdown is not open switches back to breadcrumb
navigation as expected.  Tab-focus and all other keyboard functions appear to work as
before.


Thanks,

Jonathan