Review Request: Update System Settings -> Appearance -> Style -> Workspace to permit selecting a new style via the keyboard.

Parker Coates parker.coates at kdemail.net
Wed Apr 14 20:22:27 BST 2010



> On 2010-04-11 15:47:21, Parker Coates wrote:
> > Looks good to me. Let us know if you would like it committed or would like to wait until you have an SVN account.
> > 
> > I'm now wondering if there's a way to search for all uses for QAbtractItemView's clicked() signal, as I wouldn't be surprised if this bug was present in other custom item views.
> 
> Jason Jackson wrote:
>     I'd like to do it myself as a first commit if that is ok.

Committed. See http://websvn.kde.org/?view=revision&revision=1114862


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3542/#review4967
-----------------------------------------------------------


On 2010-04-10 23:18:22, Jason Jackson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3542/
> -----------------------------------------------------------
> 
> (Updated 2010-04-10 23:18:22)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Update System Settings -> Appearance -> Style -> Workspace to permit selecting a new style via the keyboard.
> 
> 
> This addresses bug 233942.
>     https://bugs.kde.org/show_bug.cgi?id=233942
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp 1113104 
> 
> Diff: http://reviewboard.kde.org/r/3542/diff
> 
> 
> Testing
> -------
> 
> Compiled against trunk and verified that behaviour works.
> 
> 
> Thanks,
> 
> Jason
> 
>





More information about the kde-core-devel mailing list