Review Request: Add "QString iconName()" method to KIcon

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3585/#review5019
-----------------------------------------------------------


I think David proposed to add a Qt function iconEngine() in QIcon. Adding every icon to a hash does not really look like something we want...

- Christoph


On 2010-04-13 14:04:10, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3585/
> -----------------------------------------------------------
> 
> (Updated 2010-04-13 14:04:10)
> 
> 
> Review request for kdelibs, Marco Martin and Hamish Rodda.
> 
> 
> Summary
> -------
> 
> This patch is a necessary step for dbusmenu [1]: To be able to export a menu over dbus, we need to know the name of the icons, thus the need for a "QString KIcon::iconName()" method.
> 
> As you can see in the code comment, I am not really happy with the way it is implemented, but do not see any other way.
> 
> [1] http://people.canonical.com/~agateau/dbusmenu/
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/icons/kicon.h 1114121 
>   trunk/KDE/kdelibs/kdeui/icons/kicon.cpp 1114121 
> 
> Diff: http://reviewboard.kde.org/r/3585/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aurélien
> 
>