Review Request: Show meta information in KPropertiesDialog like in KDE 3

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3597/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

In KDE 4 the meta information tab from KPropertiesDialog has been disabled for several reasons. The attached patch enables this functionality again, by using the (just a few weeks ago added) class KFileMetaDataWidget. Some polishing is still required, but the main intention to post this patch on the reviewboard is because I had to move KFileMetaDataWidget + private classes from kdelibs/kfile to kdelibs/kio/kfile to prevent a cyclic dependency.

I've recompiled kdelibs from scratch and cleaned the libs, bin, include-dirs, however it would be great if someone could also try to apply the patch locally before I commit. Thanks!


Diffs
-----

  trunk/KDE/kdelibs/kfile/kcommentwidget_p.h 1114071 
  trunk/KDE/kdelibs/kfile/CMakeLists.txt 1114071 
  trunk/KDE/kdelibs/kfile/kcommentwidget.cpp 1114071 
  trunk/KDE/kdelibs/kfile/kedittagsdialog.cpp 1114071 
  trunk/KDE/kdelibs/kfile/kedittagsdialog_p.h 1114071 
  trunk/KDE/kdelibs/kfile/kfilemetadataconfigurationwidget.h 1114071 
  trunk/KDE/kdelibs/kfile/kfilemetadataconfigurationwidget.cpp 1114071 
  trunk/KDE/kdelibs/kfile/kfilemetadataprovider.cpp 1114071 
  trunk/KDE/kdelibs/kfile/kfilemetadataprovider_p.h 1114071 
  trunk/KDE/kdelibs/kfile/kfilemetadatawidget.h 1114071 
  trunk/KDE/kdelibs/kfile/kfilemetadatawidget.cpp 1114071 
  trunk/KDE/kdelibs/kfile/kloadfilemetadatathread.cpp 1114071 
  trunk/KDE/kdelibs/kfile/kloadfilemetadatathread_p.h 1114071 
  trunk/KDE/kdelibs/kfile/knfotranslator.cpp 1114071 
  trunk/KDE/kdelibs/kfile/knfotranslator_p.h 1114071 
  trunk/KDE/kdelibs/kfile/ktaggingwidget.cpp 1114071 
  trunk/KDE/kdelibs/kfile/ktaggingwidget_p.h 1114071 
  trunk/KDE/kdelibs/kio/CMakeLists.txt 1114071 
  trunk/KDE/kdelibs/kio/kfile/kmetaprops.h 1114071 
  trunk/KDE/kdelibs/kio/kfile/kmetaprops.cpp 1114071 

Diff: http://reviewboard.kde.org/r/3597/diff


Testing
-------


Thanks,

Peter