Review Request: Use QLinearGradient in KGradientSelector

Christoph Feck christoph at maxiom.de
Sun Apr 11 19:49:07 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3565/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Apparently, the old code comes from Qt 3 times, where no gradients where available. Additionally, the code allows transparent colors in the gradient, and draws them over a black/white chessboard pattern. I need this for alpha support KColorDialog (will prepare a separate review request for that).


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/widgets/kselector.cpp 1113745 

Diff: http://reviewboard.kde.org/r/3565/diff


Testing
-------

Compiles and works. It should be faster also, but I did not make any benchmark.


Thanks,

Christoph





More information about the kde-core-devel mailing list