Review Request: Update System Settings -> Appearance -> Style -> Workspace to permit selecting a new style via the keyboard.

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3542/#review4967
-----------------------------------------------------------

Ship it!


Looks good to me. Let us know if you would like it committed or would like to wait until you have an SVN account.

I'm now wondering if there's a way to search for all uses for QAbtractItemView's clicked() signal, as I wouldn't be surprised if this bug was present in other custom item views.

- Parker


On 2010-04-10 23:18:22, Jason Jackson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3542/
> -----------------------------------------------------------
> 
> (Updated 2010-04-10 23:18:22)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Update System Settings -> Appearance -> Style -> Workspace to permit selecting a new style via the keyboard.
> 
> 
> This addresses bug 233942.
>     https://bugs.kde.org/show_bug.cgi?id=233942
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp 1113104 
> 
> Diff: http://reviewboard.kde.org/r/3542/diff
> 
> 
> Testing
> -------
> 
> Compiled against trunk and verified that behaviour works.
> 
> 
> Thanks,
> 
> Jason
> 
>