Review Request: Update System Settings -> Appearance -> Style -> Workspace to permit selecting a new style via the keyboard.

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3542/#review4962
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp
<http://reviewboard.kde.org/r/3542/#comment4409>

    I think this should be
    
    connect(themeUi.m_theme->selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)), this, SLOT(setDesktopDirty()));
    
    If we use the activated signal, then the user is required to press Enter to "activate" the selection with the keyboard, which I don't think is standard in KDE. Most list views that I can think of don't require the extra keypress.
    
    Also note that the signal parameter should be normalised here. (Not that that's your fault, but it would make sense to fix it.)


- Parker


On 2010-04-10 11:44:50, Jason Jackson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3542/
> -----------------------------------------------------------
> 
> (Updated 2010-04-10 11:44:50)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Update System Settings -> Appearance -> Style -> Workspace to permit selecting a new style via the keyboard.
> 
> 
> This addresses bug 233942.
>     https://bugs.kde.org/show_bug.cgi?id=233942
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp 1113104 
> 
> Diff: http://reviewboard.kde.org/r/3542/diff
> 
> 
> Testing
> -------
> 
> Compiled against trunk and verified that behaviour works.
> 
> 
> Thanks,
> 
> Jason
> 
>