Review Request: Open selected files with default application in file manager
Todd
toddrme2178 at gmail.com
Sat Apr 10 22:27:16 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3163/
-----------------------------------------------------------
(Updated 2010-04-10 21:27:16.207380)
Review request for kdelibs.
Changes
-------
There might have been a small error somewhere in the previous diff, this version should work though.
Summary
-------
When files are selected in the file browser and the right-click menu is opened, adds an option above the "Open with..." sub-menu to open all the files in their respective preferred applications. If all files have the same preferred application, it says "Open with <application>" and uses that application's icon, otherwise it just uses says "Open" and does not have an icon.
This is similar to the behavior in dolphin where selecting multiple files and hitting "enter" opens those files in the preferred application. In order to maintain consistency, this patch also changes Dolphin to use the same slot as as the file manager right-click menu. The old Dolphin implementation just iterated through the list of files, opening each one in its default application. It did not have any way to deal with multiple files having the same default application.
Diffs (updated)
-----
/trunk/KDE/kdebase/apps/dolphin/src/dolphinviewcontroller.h 1113399
/trunk/KDE/kdebase/apps/dolphin/src/dolphinviewcontroller.cpp 1113399
/trunk/KDE/kdelibs/kio/kio/kfileitemactions.h 1110986
/trunk/KDE/kdelibs/kio/kio/kfileitemactions.cpp 1110986
/trunk/KDE/kdelibs/kio/kio/kfileitemactions_p.h 1110986
/trunk/KDE/kdelibs/kio/kio/renamedialog.h 1110986
/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1110986
Diff: http://reviewboard.kde.org/r/3163/diff
Testing
-------
Thanks,
Todd
More information about the kde-core-devel
mailing list