Review Request: Extend KStandardDirs::find[All]Exe() to also look for .com, and .bat on Windows

[Thomas Friedrichsmeier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3388/
-----------------------------------------------------------

(Updated 2010-04-07 10:28:47.567453)


Review request for kdelibs, Jaroslaw Staniek and Patrick Spendrin.


Changes
-------

The third version of the diff incorporates the changes suggested by Rolf Eike Beer on kde-core-devel.


Summary
-------

On Windows, KStandardDirs::findExe(), and findAllExe() append ".exe" to the filename to look for. However, executable files on Windows may also end in .com or .bat. Therefore, this patch looks for all three extensions in the order .exe, .com, .bat.

For example, rkward ships with a wrapper script rkward.bat. kwinstartmenu relies on KStandardDirs::findExe() to locate the executables referenced in .desktop files, and fails to find rkward.bat. This patch fixes that.


P.S.: Where should windows-specific review requests go to?


Diffs (updated)
-----

  trunk/KDE/kdelibs/kdecore//kernel/kstandarddirs.cpp 1106410 

Diff: http://reviewboard.kde.org/r/3388/diff


Testing
-------

Non-systematic. kwinstartmenu now adds rkward as expected. All other apps are added as before.

Ironically, the unittests all fail for me due to failure to find the test executables (also without this patch!), so I cannot run them, ATM.


Thanks,

Thomas