Review Request: Fix "About KDE" dialog links to the KDE website (after the reorganization)
Darío Andrés
andresbajotierra at gmail.com
Thu Apr 1 22:18:07 BST 2010
> On 2010-03-28 09:32:32, Ingo Klöcker wrote:
> > Are the links supposed to be changed for different languages? If not, then I suggest moving the links, i.e. the <a> tags, out of the localizeable text by replacing them with %1 placeholders. This would allow easy adaption of the links without breaking the translation.
> >
> > FWIW, we do this for KMail's About text and so far no translator has complained about this.
Yes, it should have used placeholders from the beggining, but I guess nobody thought the website urls may have change in the future...
Should I propose a new patch ? Thanks for the reviews
- Darío
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3411/#review4709
-----------------------------------------------------------
On 2010-03-27 16:30:01, Darío Andrés wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3411/
> -----------------------------------------------------------
>
> (Updated 2010-03-27 16:30:01)
>
>
> Review request for kdelibs and Albert Astals Cid.
>
>
> Summary
> -------
>
> Update the link to send Donations.
> Additionally, update the link for GettingInvolved (to avoid one redirection)
>
> Only web addresses are modified so I don't know if this could be backported to 4.4.. Albert?
>
> As another measure (for people still using KDE SC 4.3 or 4.4.x) we could add a header note in www.kde.org/support/ saying something like "Looking for a way to contribute with donations? Click here" (or something like that)
>
>
> This addresses bugs 226223 and 226309.
> https://bugs.kde.org/show_bug.cgi?id=226223
> https://bugs.kde.org/show_bug.cgi?id=226309
>
>
> Diffs
> -----
>
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/dialogs/kaboutkdedialog_p.cpp 1107102
>
> Diff: http://reviewboard.kde.org/r/3411/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Darío
>
>
More information about the kde-core-devel
mailing list