Review Request: Disable 'Leaving secure site warning' in browserrun.cpp

Dawit A. adawit at
Mon Sep 28 15:27:10 BST 2009

On Monday 28 September 2009 09:47:06 you wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> -----------------------------------------------------------
> Did you test that the warning still appears when clicking on links, in both
>  web engines, in both the "standalone page" case and inside frames?
>  BrowserRun is used as a base class in both konqueror (KonqRun) and khtml
>  (BrowserRun, used for frames). I'm not 100% sure, but I'm afraid this
>  change might have removed the warnings in a case where they are needed.
>  Hmm, well, the metadata comes from khtmlpart in the first place, so maybe
>  it works, I just want to ask if you tested the case where the warnings
>  -should- appear :-)

I tested the standalone case. I did not admittedly test the frame case, but 
that is something khtml has to handle internally on its own because that is a 
rather complicated situation when frames are involved. However, as far as I 
was able to tell from looking at KHTMLPart::urlSelected which seems to be the 
function that is invoked when you click on a url, the "ssl_activate_warnings" 
meta data is properly set there. Now if I can only find an SSL site with frames 
that contain non SSL links, I can validate that is the case for sure. :)

More information about the kde-core-devel mailing list