Review Request: Disable 'Leaving secure site warning' in browserrun.cpp

[adawit at kde.org]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1715/
-----------------------------------------------------------

(Updated 2009-09-27 00:03:23.830932)


Review request for kdelibs.


Summary
-------

This patch disables the 'leaving secure site' warning from being displayed when the user types a new address in the location bar while visiting an SSL secured site. 

As far as I am concerned it only makes sense to prompt the user with such warning on non-secure link navigation, i.e. a click on a link in a secure page that points to a non-secure page or a non-secure script based navigation which the user might not notice. And these two situations are conditions that should be handled by the browsing engines directly.


Diffs
-----

  /branches/KDE/4.3/kdelibs/kparts/browserrun.cpp 1024592 

Diff: http://reviewboard.kde.org/r/1715/diff


Testing (updated)
-------

Tested with both webkit and khtml rendering engines.


Thanks,

adawit