Review Request: Adding support to KMimeType for guessing the mimetype by content fetched from an abstract QIODevice

Michael Pyne mpyne at
Sat Sep 26 19:51:04 BST 2009

On Saturday 26 September 2009 12:14:51 Friedrich W. H. Kossebau wrote:
> There is no new logic contained in this patch, but (just) two more symbols
>  to the API, resulting in a more powerful usage of KMimeType due to the
>  abtract QIODevice interface which can now be passed as content provider
>  instead of only a (local) file or a QByteArray.
> So I am considering to simply commit it. But I still would like at least
>  one +1 from someone with insight.

The patch looks technically correct (and I agree with the idea behind it as 
well).  I don't have any background insight as to KMT however.

One quibble is that findByNameAndContent is missing the @return APIDOX.

Other than that it looks fine to me.

 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list