[PATCH] Turn Powerdevil suspend notification into a dialog

[Aurélien Gâteau]

Sebastian Kügler wrote:
> On Tuesday 22 September 2009 14:19:57 Aurélien Gâteau wrote:
>> What do you think about this?
> 
> NAK. The notification comes from the system, the workspace (which is where powerdevil 
> lives) not from an application, it's also where other notifications of system 
> hardware state come from (network connected, power connected, ...) that's where it 
> should stay.

This is a notification about an event which is more serious than network 
connected: you could even loose data if you configured your machine to 
shutdown when running out of power. That's why I believe it makes sense 
to use a dialog here.

> Having it in a notification, and thus always in the same location 
> actually makes it a lot easier to find the dialog, especially when you're in a hurry.
> Making it a dialog would be a step back IMO as it looks less integrated and those 
> small dialog windows tend to get lost behind other windows.

You missed the point where I said the dialog is:
- always on top
- on all desktops
- does not steal focus

>> The second patch increases the default timeout from 10 seconds to 30 
>> seconds, giving the user more time to react.
> 
> OK from my POV, but probably 20 seconds is also enough. I've never missed to cancel a 
> suspend even with it being 10 seconds. (Maybe this part of the patch is a sign that 
> it now takes you longer to locate the cancel action?)

No, it was something I wanted to fix for a long time. It is especially 
an issue on machines with not-so-precise touchpads. And since 
notifications can't be reached with keyboard, you need to use it (the 
dialog, on the other hand is more keyboard friendly).

Aurelien