Review Request: fix some khtml krazy2 warnings.

Maksim Orlovich maksim.orlovich at kdemail.net
Mon Sep 21 15:49:10 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1639/#review2412
-----------------------------------------------------------

Ship it!


Looks fine, thanks.

- Maksim


On 2009-09-18 22:44:04, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1639/
> -----------------------------------------------------------
> 
> (Updated 2009-09-18 22:44:04)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Fixed some spelling mistakes. (trivial)
> Changed the a=QString() with a.clear(), except in one place where the member is of type DOMString.
> Added a hint for krazy2 to not check the code generated by gperf. Used the latest version to generate the file doctypes.cpp.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/html/doctypes.cpp 1025361 
>   /trunk/KDE/kdelibs/khtml/html/doctypes.gperf 1025361 
>   /trunk/KDE/kdelibs/khtml/html/htmlprospectivetokenizer.h 1025361 
>   /trunk/KDE/kdelibs/khtml/html/htmlprospectivetokenizer.cpp 1025361 
>   /trunk/KDE/kdelibs/khtml/rendering/bidi.cpp 1025361 
>   /trunk/KDE/kdelibs/khtml/rendering/render_style.cpp 1025361 
>   /trunk/KDE/kdelibs/khtml/rendering/render_table.cpp 1025361 
>   /trunk/KDE/kdelibs/khtml/rendering/table_layout.cpp 1025361 
>   /trunk/KDE/kdelibs/khtml/svg/animation/SMILTimeContainer.h 1025361 
>   /trunk/KDE/kdelibs/khtml/ui/findbar/khtmlfindbar.cpp 1025361 
>   /trunk/KDE/kdelibs/khtml/xml/dom_docimpl.cpp 1025361 
>   /trunk/KDE/kdelibs/khtml/xml/dom_nodeimpl.h 1025361 
> 
> Diff: http://reviewboard.kde.org/r/1639/diff
> 
> 
> Testing
> -------
> 
> kdelibs compiles and konqueror passes the acid tests with the same score.
> 
> 
> Thanks,
> 
> Jaime
> 
>





More information about the kde-core-devel mailing list