Review Request: Make KFilterProxySearchLine look more like KDEs searchlines

[Alessandro Diaferia]

2009/9/17 Alessandro Diaferia <alediaferia at gmail.com>

>
>
> 2009/9/17 Christoph Feck <christoph at maxiom.de>
>
>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/1622/#review2392
>> -----------------------------------------------------------
>>
>>
>> The HBox can also be removed, as it only contains the LineEdit now.
>>
>> About the "Search..." string, do we need the dots here? At least,
>> systemsettings does not have them.
>>
>> - Christoph
>>
>>
>> On 2009-09-17 09:41:42, Alessandro Diaferia wrote:
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > http://reviewboard.kde.org/r/1622/
>> > -----------------------------------------------------------
>> >
>> > (Updated 2009-09-17 09:41:42)
>> >
>> >
>> > Review request for kdelibs.
>> >
>> >
>> > Summary
>> > -------
>> >
>> > Imho using KLineEdit::setClickMessage is nicer and more common into KDE
>> instead of an additional QLabel. I left the inheritance from QWidget as is
>> since future additions would be made more easily but the widget could
>> directly inherit from KLineEdit now.
>> >
>> > Suggestions/insults are welcome :)
>> >
>> > Cheers
>> >
>> >
>> > Diffs
>> > -----
>> >
>> >   trunk/KDE/kdelibs/kdeui/itemviews/kfilterproxysearchline.cpp 1023670
>> >
>> > Diff: http://reviewboard.kde.org/r/1622/diff
>> >
>> >
>> > Testing
>> > -------
>> >
>> >
>> > Thanks,
>> >
>> > Alessandro
>> >
>> >
>>
>>
> I just used the dots looking at the nepomuk search line used in dolphin..
> Wil remove them along with the KHBox include as well in the case they are
> not needed :)
>
> --
> Alessandro Diaferia
> KDE Developer
>

Ok I misunderstood. How can I remove the QHBoxLayout keeping the lineedit
still full size?

-- 
Alessandro Diaferia
KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090917/da1cbaa0/attachment.htm>