Review Request: Adding kinetic scrolling in plasma::ScrollWidget

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1614/#review2389
-----------------------------------------------------------

Ship it!


apart those little issues below, to me is good as a first version.
then all the todo item can be implemented once in trunk


svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp
<http://reviewboard.kde.org/r/1614/#comment1701>

    - horizontal scrolling as well, that can occur simoultaneously to the vertical one



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp
<http://reviewboard.kde.org/r/1614/#comment1700>

    constants :)



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp
<http://reviewboard.kde.org/r/1614/#comment1698>

    kinMovement



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp
<http://reviewboard.kde.org/r/1614/#comment1699>

    enum {
        None,
        Up,
        Down
    }


- Marco


On 2009-09-17 06:40:32, Adenilson Cavalcanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1614/
> -----------------------------------------------------------
> 
> (Updated 2009-09-17 06:40:32)
> 
> 
> Review request for kdelibs, Aaron Seigo, Marco Martin, and igorto.
> 
> 
> Summary
> -------
> 
> Adding kinetic scrolling in plasma::ScrollWidget using timers.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/CMakeLists.txt 1024622 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h PRE-CREATION 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1024622 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1024622 
> 
> Diff: http://reviewboard.kde.org/r/1614/diff
> 
> 
> Testing
> -------
> 
> Up until now, only tested it with uBlog and plasma-netbook, not sure how it will work with another plasma apps.
> 
> It was also tested (I mean the pure Qt version of kinetic scrolling list: http://repo.or.cz/w/kineticlist.git) in a N810 with Qt 4.5.2 and it runs pretty smoothly.
> 
> 
> Thanks,
> 
> Adenilson
> 
>