Review Request: New KSignalPlotter graph for plotting continuous data as it comes in

David Faure faure at kde.org
Mon Sep 14 12:08:58 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1430/#review2346
-----------------------------------------------------------


The rule in kdelibs is "2 (preferrably 3) other apps wanting to use it".
>From what you say, this isn't the case yet, right?

Of course this is a chicken-and-egg problem, people can't use it if it's not available.
But in fact this is what http://techbase.kde.org/Projects/Widgets_and_Classes is for (I suggest you add the class there), and well, this very review request would also trigger "I want this" from app authors who need something like this, if there were ;-)
Meanwhile I don't think we should put this in kdelibs - no point in forcing ourselves into SC/BC rules until necessary.

- David


On 2009-08-29 10:45:29, John Tapsell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1430/
> -----------------------------------------------------------
> 
> (Updated 2009-08-29 10:45:29)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is used by KSysGuard to plot network usage etc.  I want to make it available for other people to use.
> 
> It is really quite feature-full, and uses a sliding window technique to minimize CPU usage for drawing.  On my system (dual core 3Ghz), drawing three of these graphs updating every 0.5 seconds takes about 1% of the CPU usage.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeui/plotting/KSignalPlotter.h PRE-CREATION 
>   trunk/KDE/kdeui/plotting/KSignalPlotter.cpp PRE-CREATION 
>   trunk/KDE/kdeui/plotting/KSignalPlotter_p.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1430/diff
> 
> 
> Testing
> -------
> 
> It has been used in KSysGuard for ages.
> 
> It has no unit tests however :-/
> 
> 
> Screenshots
> -----------
> 
> Screenshot in action
>   http://reviewboard.kde.org/r/1430/s/191/
> 
> 
> Thanks,
> 
> John
> 
>





More information about the kde-core-devel mailing list