Review Request: Fix some memory leaks in the Fonts Installer KCM
Darío Andrés
andresbajotierra at gmail.com
Fri Sep 11 01:47:16 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1567/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
I'm not confident about this one (about the Fc* function calls), and as I don't know if this KCM has a current maintainer to ping, I'm leaving the patch here to discuss.
Diffs
-----
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/kfontinst/lib/FcEngine.h 1021986
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/kfontinst/lib/FcEngine.cpp 1021986
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/kfontinst/viewpart/FontPreview.cpp 1021986
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/kcontrol/kfontinst/kcmfontinst/FontFilterProxyStyle.cpp 1021986
Diff: http://reviewboard.kde.org/r/1567/diff
Testing
-------
It fixes several memory leaks easily found running the KCM using valgrind.
Thanks,
Darío
More information about the kde-core-devel
mailing list