Merging KAuth into KDELibs

[Aaron J. Seigo]

On September 2, 2009, Christoph Feck wrote:
> Am Saturday 29 August 2009 14:09:40 schrieb Dario Freddi:
> > On Saturday 29 August 2009 14:02:20 Aaron J. Seigo wrote:
> > > (and the first stop of libkauth would be kdereview :)
> >
> > Been there already :) we moved it to a branch first to prepare for
> > merging and avoid disasters
>
> When has the review phase been? 

apparently some time ago. at least that's what i was told :)

> Looking at it now in trunk, I see several issues (albeit small):
>
> * should be slots -> Q_SLOTS and signals -> Q_SIGNALS in public headers
> * should add const to Private *d for the d-ptr
> * comments say "namespace Auth", but it is KAuth
> * private includes should be named *_p.h
> * include guards do not match file names (e.g. kauthhelpersupport.h has
> HELPER_SUPPORT_H)
> * many trailing whitespace and other formatting issues
> * missing 4.4 tags (I only checked KPushButton header)

all correct, and all easily fixed. feel free to help out if you wish, 
otherwise i'll do this tomorrow if Dario doesn't get to it.

> * mixed case in cpp/h file names allowed?

should probably be all lowercase for consistency in that lib, but not a deal 
breaker. the installed headers are lower case.

> * ActionWatcher only has two private constructors?

yes. you can get a Watcher, but you don't create them yourself.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Framework
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090902/cdb0ff24/attachment.sig>