[PATCH] Detecting notification popup server capabilities

[Aaron J. Seigo]

On September 2, 2009, Aurélien Gâteau wrote:
> Instead I am going to patch knotify4 to silently discard actions when
> running in an action-less notification environment.

why? what does that gain us except discouraging other envs from providing 
support for actions, more special cases in our code and give developers the 
hint that actions are "bad" in some way?

the specification include actions and it's up to the server to ignore them or 
support them. the client does need to do anything. to quote directly from 

http://www.galago-project.org/specs/notification/0.9/x408.html#command-get-
capabilities

"Even if this ["actions"] cap[ability] is missing, actions may still be 
specified by the client, however the server is free to ignore them. "

and there's no real overhead saved by removing the actions since the actions 
go across the bus with the rest of the notification information.

> As Olivier said,
> developers should not assume that actions are always displayed, since
> most knotify notification plugins do not support them.

"most" as in "numerically greatest". our primary target environment does 
support them, however.

and the only cases i can think of that really *require* such actions be 
visible only run in the KDE Workspace (e.g. KDE's power management 
infrastructure). 

> Do you think this patch could be upstreamed?

imho, no.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Framework
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090902/d46627b9/attachment.sig>