Review Request: Make KSqueezedTextLabel::text() return the full text
Sebastian Trueg
trueg at kde.org
Fri Oct 30 11:11:36 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1985/
-----------------------------------------------------------
(Updated 2009-10-30 11:11:36.004655)
Review request for kdelibs.
Changes
-------
* Renamed method to fullText
* Added the missing ';'
Summary
-------
KSqueezedTextLabel is a nice convenience class but its text method does return the squeezed test which is useless. Thus, I reimplemented the text method. The only problem with this is: QLabel::text is not virtual. So the question is: should I rename it to fullText()?
Diffs (updated)
-----
trunk/KDE/kdelibs/kdeui/widgets/ksqueezedtextlabel.h 1042592
trunk/KDE/kdelibs/kdeui/widgets/ksqueezedtextlabel.cpp 1042592
Diff: http://reviewboard.kde.org/r/1985/diff
Testing
-------
Thanks,
Sebastian
More information about the kde-core-devel
mailing list