Review Request: dom range arguments passing by reference instead of by value

[Maksim Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2011/#review2857
-----------------------------------------------------------


It's binary incompatible; plus nodes are one pointer wide anyway.
(Also unrelated to acid3 test 0).

- Maksim


On 2009-10-29 20:11:46, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2011/
> -----------------------------------------------------------
> 
> (Updated 2009-10-29 20:11:46)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Is this a Binary incompatible change?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/dom/dom2_range.h 1041906 
>   /trunk/KDE/kdelibs/khtml/dom/dom2_range.cpp 1041906 
> 
> Diff: http://reviewboard.kde.org/r/2011/diff
> 
> 
> Testing
> -------
> 
> For the first time, after this change, the acid3 test did not showed me that test00 was slow.
> 
> 
> Thanks,
> 
> Jaime
> 
>