kdewebkit moved to kdereview

[Aaron J. Seigo]

On October 29, 2009, Dawit A. wrote:
> On Wednesday 28 October 2009 10:07:55 Marco Martin wrote:
> > On Wednesday 28 October 2009, Dawit A. wrote:
> > > On Tuesday 27 October 2009 22:02:10 Chani wrote:
> > > > > > i ask because there is now a QGraphicsWebView included with
> > > > > > QtWebkit which Plasma eventually will be using instead of our own
> > > > > > QWebPage-behind-a- QGraphicsWidget implementation that we
> > > > > > currently use; being able to set the KWebPage on a
> > > > > > QGraphicsWebView and get everything, including KWallet
> > > > > > integration, would be optimal.
> > > > >
> > > > > That is exactly the kind of thing KWebPage is actually designed to
> > > > > solve. You use it in place of its Qt counter part to get all of the
> > > > > KDE integration for free...
> > > >
> > > > yes but in plasma we need a *graphics*widget, not a widget. are you
> > > > going to provide that?
> > >
> > > Well if you mean are we going to provide a KDE re-implementaion of
> > > QGraphicsWebView, then there is no plan to do that at this point.
> >
> > nope, because we can't use a QWidget at all, too overhead for a thing
> > like that
> 
> Unlike QWebView QGraphicsWebView inherits from QGraphicsWidget not
>  QWidget...

i think you're both saying the same thing. regardless, i think we really ought 
to have a KGraphicsWebView subclass of QGrahpicsWebView that is an analog for 
KWebView. this will make it easier to track changes in KWebKit. if you're cool 
with that, i'd be happy to add such a thing to KWebKit. it would include the 
same add-on features as in KWebView:

* consistent mouse button keyboard modifiers

* external content access control

in fact, i'd probably put all the logic for this in a share private class and 
then have the private classes subclass from that. this would prevent code 
duplication from creeping in over time.

would you be cool with that? (i'm already nearly done, hoping you'll say yes, 
in fact ;)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091029/3ed73d35/attachment.sig>