Review Request: Improve spell check context menu

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2007/#review2850
-----------------------------------------------------------



/trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp
<http://reviewboard.kde.org/r/2007/#comment2208>

    #include "ktextedit.h" (the "own" include) must always be the first include. Move this one.



/trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp
<http://reviewboard.kde.org/r/2007/#comment2216>

    Title case for menu items, please. "Spell Language".



/trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp
<http://reviewboard.kde.org/r/2007/#comment2209>

    I am not sure if it is wise to have the suggestions both at the top level menu, as well as sub menu entries.



/trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp
<http://reviewboard.kde.org/r/2007/#comment2210>

    use !reps.isEmpty()



/trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp
<http://reviewboard.kde.org/r/2007/#comment2207>

    You need to delete the "new"ly created objects after the menu is hidden, or you get a memory leak. I guess it is also just possible to use function local variables, instead of heap allocated.



/trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp
<http://reviewboard.kde.org/r/2007/#comment2214>

    This is a nice addition. I think there is even a separate bug report/request about being able to change the spell checking language from the spell checking context menu.


- Christoph


On 2009-10-29 08:14:51, Ilya Hegai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2007/
> -----------------------------------------------------------
> 
> (Updated 2009-10-29 08:14:51)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> #194979 JJ: Improve spell check context menu
> 
> http://techbase.kde.org/Projects/PIM/KMail_Junior_Jobs#Bug_194979:_Improve_spell_check_context_menu
> 
> 
> This addresses bug 194979.
>     https://bugs.kde.org/show_bug.cgi?id=194979
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp 1041580 
> 
> Diff: http://reviewboard.kde.org/r/2007/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ilya
> 
>