Review Request: KIO: KDesktopFileActions: Improve (un)mounting actions logic

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1995/#review2846
-----------------------------------------------------------


from readin, this patch doesn't behave any differently than the current code. i suppose that's why you noted it is just preparation? i'd suggest resubmitting when the code actually takes advantage of such capabilities, as right now it only makes the code harder to read without any current advantage. that said, i would like to see the mount/unmount offering done smarter :)

- Aaron


On 2009-10-28 13:13:09, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1995/
> -----------------------------------------------------------
> 
> (Updated 2009-10-28 13:13:09)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> We need better decisions for (un)mounting. For example unmounted CD - this can be both: ejected and mounted. Or something like / (root) partition. It is mounted but can not be unmounted.
> 
> This patch prepares code for such a cases.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/kdesktopfileactions.cpp 1041546 
> 
> Diff: http://reviewboard.kde.org/r/1995/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rafa?
> 
>