Review Request: static_casts for dom
Simon St James
kdedevel at etotheipiplusone.com
Wed Oct 28 22:00:58 GMT 2009
Hi all,
Quick hiack:
On Wednesday 28 October 2009 20:54:01 Jaime Torres wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2002/
> -----------------------------------------------------------
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> replace all (I hope) the C casts with C++ casts in khtml/dom
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/khtml/dom/css_extensions.cpp 1041906
> /trunk/KDE/kdelibs/khtml/dom/dom_text.cpp 1041906
> /trunk/KDE/kdelibs/khtml/dom/html_base.cpp 1041906
> /trunk/KDE/kdelibs/khtml/dom/html_document.cpp 1041906
> /trunk/KDE/kdelibs/khtml/dom/html_image.cpp 1041906
> /trunk/KDE/kdelibs/khtml/dom/html_inline.cpp 1041906
> /trunk/KDE/kdelibs/khtml/dom/html_object.cpp 1041906
> /trunk/KDE/kdelibs/khtml/dom/html_table.cpp 1041906
I'm not sure if you hunted these down manually, but I have a locally patched
GDB that warns on all C-style cast, and gives a breakdown of how they are
interpreted (static_cast, static_cast from base to derived [pointer/
reference], reinterpret_cast, const_cast etc). Is there any interest in
having a list of all of these for some KDE modules at all?
Best Wishes,
Simon
More information about the kde-core-devel
mailing list