kdewebkit moved to kdereview

[Dawit A.]

On Tuesday 27 October 2009 11:53:53 Benjamin Meyer wrote:
> On Oct 27, 2009, at 10:40 AM, Dawit A. wrote:
> > On Sunday 25 October 2009 20:40:16 Benjamin Meyer wrote:
> >> On Oct 25, 2009, at 7:35 PM, Chani wrote:
> >>> On October 25, 2009 15:57:49 Sebastian Kügler wrote:
> >>>> On Sunday 25 October 2009 22:40:47 Urs Wolfer wrote:
> >>>>> On Sunday 25 October 2009 22:05:08 Sebastian Kügler wrote:
> >>>>>> On Sunday 25 October 2009 20:02:51 Urs Wolfer wrote:
> >>>>>>> I have just moved the kdewebkit lib from
> >>>>>>> playground/libs/webkitkde/kdewebkit  into kdereview. It's the
> >>>>>>> KDE
> >>>>>>> integration part of QtWebKit which is used directly in many apps
> >>>>>>> and
> >>>>>>> libs already (...which does not include the WebKit KPart). Any
> >>>>>>> KDE
> >>>>>>> app is supposed to move to this integration lib when it is in
> >>>>>>> kdelibs
> >>>>>>> (plans are to move it to kdelibs/kdewebkit).
> >>>>>>
> >>>>>> Could you briefly explain what features this brings? That might
> >>>>>> make it
> >>>>>> easier for people to understand why it's needed ...
> >>>>>
> >>>>> Sure. The main point is for sure the integration of KIO. Without
> >>>>> kdewebkit,  any app which is using QWeb* classes does network
> >>>>> interactions without KDE technologies. Other points are for
> >>>>> example:
> >>>>> * using KDE icons in context menu
> >>>>> * using KDE plugins (for example nsplugins flash)
> >>>>> * KDE dialogs for javascript dialogs (alert, file picker, ..)
> >>>>
> >>>> Great stuff. :) One thing I've been asking myself is if it all
> >>>> works in the
> >>>> same way for QGraphicsWebView (the canvas based QGraphicsWidget).
> >>>> Are you
> >>>> planning to add password saving / kwallet integration as well?
> >>>
> >>> kwallet kwallet kwallet! :)
> >>> it's the most vital part of kde integration for me (yes, even more
> >>> that the
> >>> filedialog ;). I have zillions of passwords I can't be bothered to
> >>> remember.
> >>
> >> For password management there are two parts, the first is the
> >> QtWebKit
> >> side (grabbing and loading forms) and the second is the hook to
> >> KWallet via dbus.  I have finished the first part in Arora and
> >> currently just save dump to disk the form data.  If someone wants to
> >> help do the second part we could create a working code base that
> >> could
> >> be shared.
> >
> > I do not mind taking a stub at the KWallet portion specially since I
> > can cheat
> > and look at what has already been done by khtml as a starting point.
> > Out of
> > curiosity though how were you able to obtain form data from QtWebKit
> > in Qt 4.5
> > or were you able to achieve that through the new QWebElement API in
> > Qt 4.6 ?
> > Anyhow, I will look into this when I get the chance soon unless
> > someone else
> > beats me to it...
> 
> It works with Qt 4.5 by using some basic javascript.  Of course once
> that is converted to QWebElement it will be cleaner code.  But the
> vast majority of the code wasn't the javascript portion.

I see... I was wondering how Arora gained form completion in recent releases. 
I have 0.10.1 installed here. Anyhow, I will see what I can do in terms of an 
API for KWallet integration...