Review Request: Add new X11 Qt keys to KKeyServer

Michael Jansen kde at michael-jansen.biz
Mon Oct 26 18:43:27 GMT 2009


Since noone else is answering i will put my 2cents here. I want to say "Ship 
it". I have to say: "As long as qt doesn't accept the merge request this is a 
no go".

And i know how long that can take.

The same for the next merge request depending on this one. I haven't look at 
the patch itself btw. . There is no need to do that until it really can go in.

Sorry.

Mike


On Friday 23 October 2009 14:52:10 Felix Geyer wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1950/
> -----------------------------------------------------------
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The required Qt patch already is in kde-qt and there is a merge request for
>  Qt master branch:
>  http://qt.gitorious.org/+kde-developers/qt/kde-qt/commits/patches/0288-mor
> e-x-keycodes http://qt.gitorious.org/qt/qt/merge_requests/1742
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/util/kkeyserver_x11.cpp HEAD
> 
> Diff: http://reviewboard.kde.org/r/1950/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 




More information about the kde-core-devel mailing list