Review Request: Avoid valgrind warnings about unitialized values

Maksim Orlovich maksim.orlovich at kdemail.net
Thu Oct 22 15:27:10 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1928/#review2763
-----------------------------------------------------------

Ship it!


0 is fine since this is a throw-away value anyway.

- Maksim


On 2009-10-22 13:43:17, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1928/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 13:43:17)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> If someone knows better initial values....
> For me (and valgrind), zero is better than undefined.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/rendering/render_box.cpp 1038867 
>   /trunk/KDE/kdelibs/khtml/rendering/render_flow.cpp 1038867 
> 
> Diff: http://reviewboard.kde.org/r/1928/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime
> 
>





More information about the kde-core-devel mailing list