Review Request: crash of the compiler for bidi.cpp

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1924/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

If one doesn't enable the SVG, one has a crash of the compiler for bidi.cpp:
../kdelibs/khtml/rendering/bidi.cpp:1532: error: 'SVGRootInlineBox' is not a member of 'WebCore'
and more...

because not defined at the bidi.h

So we need to use the same method at bidi.cpp

my proposal:
#if ENABLE(SVG)
                        if (lineBox->isSVGRootInlineBox()) {
                            //kDebug() << "svgrootinline box:" << endl;
                            WebCore::SVGRootInlineBox* svgLineBox = static_cast<WebCore::SVGRootInlineBox*>(lineBox);
                            svgLineBox->computePerCharacterLayoutInformation();
                        }
#endif // ENABLE(SVG)
see: bidi-gm-25.diff


Diffs
-----

  /trunk/KDE/kdelibs/khtml/rendering/bidi.cpp 1038700 

Diff: http://reviewboard.kde.org/r/1924/diff


Testing
-------


Thanks,

Guy