Review Request: css_ruleimpl.cpp:83: warning: suggest parentheses around assignment used as truth value
Guy Maurel
guy-kde at maurel.de
Mon Oct 19 16:26:43 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1895/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
The dashboard
http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdelibs/khtml/css/css_ruleimpl.cpp:83: warning: suggest parentheses around assignment used as truth value
at
void CSSFontFaceRuleImpl::setDeclaration( CSSStyleDeclarationImpl* decl)
my proposal: 2 parentheses more
see: css_ruleimpl-gm-17.diff
Diffs
-----
/trunk/KDE/kdelibs/khtml/css/css_ruleimpl.cpp 1037564
Diff: http://reviewboard.kde.org/r/1895/diff
Testing
-------
Thanks,
Guy
More information about the kde-core-devel
mailing list